feat: enhance host and port parsing to support IPv6 addresses#781
Open
podrivo wants to merge 1 commit into
Open
feat: enhance host and port parsing to support IPv6 addresses#781podrivo wants to merge 1 commit into
podrivo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #769
Problem
The CLI split the target on every colon (
target.split(':')), so IPv6 addresses broke — the first internal colon was treated as the host/port separator, even in bracketed form ([2001:db8::1]:27015):Fix
Reworked host/port parsing in
bin/gamedig.js. Besides the bracketed form, colon count disambiguates: exactly one colon meanshost:port; zero or 2+ means the whole string is the host (hostnames, IPv4, unbracketed IPv6).No downstream changes needed:
DnsResolver.resolve()already short-circuits valid IPs viaisIP(host).Compatibility
Hostnames, IPv4, and
host:portparse identically to before — only the broken IPv6 cases change.String(...)guards against Minimist coercing a numeric-only host to a number.Testing
npm run lint:checkpasses.