Fix for the addition of fractions#10
Open
SabshinK wants to merge 2 commits into
Open
Conversation
While not strictly necessary, having a get common denominator function might be useful, and this implementation works with fractions of the same denominator, so for now this will work. Later, because you shouldn't be allowed to add fractions of different denominators directly via the cauldron, we can add a check inside of the cauldron class in AddIngredient. That way, the ability to add fractions of different denominators is possible, just prevented because of how the rules of the game.
TODO statement for later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While not strictly necessary, having a get common denominator function might be useful, and this implementation works with fractions of the same denominator, so for now this will work. Later, because you shouldn't be allowed to add fractions of different denominators directly via the cauldron, we can add a check inside of the cauldron class in AddIngredient. That way, the ability to add fractions of different denominators is possible, just prevented because of how the rules of the game.