-
Notifications
You must be signed in to change notification settings - Fork 168
[WIP] Catalog v1 #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[WIP] Catalog v1 #735
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…ut needing to instantiate the full game object
|
@tturocy @rahulsavani I've implemented a draft of the catalog module in pygambit on this branch, this would already be a good point for you both to take a look at the approach and comment. Take at
You can also see how the API works by looking at the ReviewNB link above and seeing in the tutorial examples the two features of the catalog so far:
At the moment, there are just 3 example games in the catalog. One key obstacle for just trawling the games in contrib and getting them all added now is how to think about a consistent naming convention. I could just use the filenames, but presumably we want something more robust as discussed. |
… circular imports issue
…to avoid circular imports issue" This reverts commit 4d46dd5.
Issues closed by this PR
Description of the changes in this PR
This PR adds infrastructure for a catalog of games, with some examples of usage added to the tutorials 1 & 2
How to review this PR
...