Skip to content

fix: if css optimizers turn 0px to "0", fix vars inside calc functions #3566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfintal merged 1 commit into from
Jul 31, 2025
+7 −5
Merged

fix: if css optimizers turn 0px to "0", fix vars inside calc functions #3566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/block/columns/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@
@for $columns from 2 through 6 {
@for $index from 1 through $columns {
:where(body:not(.wp-admin) .stk-block-column:nth-child(#{ $index }):nth-last-child(#{ $columns - ($index - 1) })) {
flex: 1 1 calc(( 100% / #{ $columns } ) - var(--stk-column-gap, 0px) * #{ $columns - 1 } / #{ $columns }) !important;
// "* 1px" is added to prevent optimizers that remove the "px" unit from "0px" values from destroying calculations.
flex: 1 1 calc(( 100% / #{ $columns } ) - var(--stk-column-gap, 0px) * 1px * #{ $columns - 1 } / #{ $columns }) !important;
}
}
}
Expand Down
3 changes: 2 additions & 1 deletion src/block/feature-grid/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@

.stk-block-feature-grid.stk--column-wrap-desktop .stk--flex > .stk-block-column,
.stk-block-feature-grid.stk--column-wrap-desktop .stk--flex > * > * > [data-type="stackable/column"] {
flex: var(--stk-flex-grow, 1) 1 calc(100% - var(--stk-column-gap, 0px) * 0 / 1) !important;
// "* 1px" is added to prevent optimizers that remove the "px" unit from "0px" values from destroying calculations.
flex: var(--stk-flex-grow, 1) 1 calc(100% - var(--stk-column-gap, 0px) * 1px * 0 / 1) !important;
}
4 changes: 2 additions & 2 deletions src/block/posts/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
// We need this to make advanced position work.
position: relative;
// Generate a flex basis value based on the number of columns.
flex-basis: calc((100%/var(--stk-columns, 2)) - (var(--stk-column-gap, 16px)) + (var(--stk-column-gap, 16px)/var(--stk-columns, 2)));
width: calc((100%/var(--stk-columns, 2)) - (var(--stk-column-gap, 16px)) + (var(--stk-column-gap, 16px)/var(--stk-columns, 2)));
flex-basis: calc((100%/var(--stk-columns, 2)) - (var(--stk-column-gap, 16px) * 1px) + ((var(--stk-column-gap, 16px) * 1px)/var(--stk-columns, 2)));
width: calc((100%/var(--stk-columns, 2)) - (var(--stk-column-gap, 16px) * 1px) + ((var(--stk-column-gap, 16px) * 1px)/var(--stk-columns, 2)));
overflow: hidden;
// Make the contents occupy entire area.
display: flex;
Expand Down
Loading
Loading