Skip to content

fix: merge but ensure unique slug #3544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfintal merged 2 commits into from
Jul 8, 2025
Merged

fix: merge but ensure unique slug #3544

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba6cac8
fix: merge but ensure unique slug
Arukuen Jul 7, 2025
9faa927
fix: add additional error handling
Arukuen Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/hooks/use-preset-controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,18 @@ export const usePresetControls = property => {
// This happens when settings like `typography.defaultFontSizes` or `spacing.defaultSpacingSizes`
// are not explicitly set to `false` in theme.json v3.
if ( hasThemePresets && wpDefaultPresets && defaultSizesEnabled !== false ) {
themePresets = [ ..._themePresets, ...wpDefaultPresets ]
// Create a set for removing duplicates.
const existingSlugs = new Set()
_themePresets.forEach( item => {
if ( item && typeof item.slug === 'string' ) {
existingSlugs.add( item.slug )
}
} )

themePresets = [
..._themePresets,
...wpDefaultPresets.filter( item => ! existingSlugs.has( item.slug ) ),
]
}

// Get the theme/default presets if the user have one, else return the stackable presets
Expand Down
Loading