Skip to content

Migrate to null-safety #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phansier wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Migrate to null-safety #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@
## 1.1.0

- Fixed a bug: URL didn't open within the app, but in browser. Solved already

## 2.0.0

- Null-safety
6 changes: 3 additions & 3 deletions lib/src/link_base.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,18 @@ class Link extends StatelessWidget {

final Widget child;
final String url;
final VoidCallback onError;
final VoidCallback? onError;

/// In case the URL is not openable (i.e., scheme is not supported in your device), it won't launch the URL and call the onError callback if provided.
/// Otherwise, the URL will be launched within the app
const Link({Key key, @required this.url, @required this.child, this.onError: null}) : super(key: key);
const Link({Key? key, required this.url, required this.child, this.onError}) : super(key: key);

void _launch(String url) async {
if (await Launcher.canLaunch(url)) {
await Launcher.launch(url, forceWebView: true,);
} else {
if (onError != null) {
onError();
onError!();
}
}
}
Expand Down
Loading