루틴 스케줄 실패 저장 원자성 보정#231
Merged
Merged
Conversation
Closes #220
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
루틴 저장/수정/삭제 중 AlarmKit 스케줄 재구성이 실패했을 때 저장소와 실제 알림 상태가 다른 성공 상태로 남지 않도록 원자성을 보정했습니다.
🎯 Type of Change
🔗 Related Issues
📋 Changes Made
Added
RoutineError.scheduleFailed를 추가해 스케줄 실패를 권한 실패와 분리했습니다.Changed
RoutineRepositoryImpl이 후보 스케줄 재구성 성공 후에만 UserDefaults 루틴 저장소를 커밋하도록 변경했습니다.Docs/reliability-recovery.md와Docs/product-specs/routine-notifications.md에 반영했습니다.Fixed
Removed
🔍 Technical Details
scheduleNotifications -> saveRoutines로 바꿔 새 활성 루틴이 스케줄 성공 없이 저장되지 않게 했습니다.RoutineError.scheduleFailed를 throw합니다.scheduleFailureprompt를 통해 에디터를 유지하고 사용자가 재시도하거나 비활성 루틴으로 저장할 수 있게 합니다.📸 Screenshots / Videos
Before
첨부 없음
After
첨부 없음
✅ Testing
Test Plan
Test Environment
125B9A31-6A4A-466D-A8AB-410730B22446)Test Results
make lint통과make arch-check통과xcodebuild test -workspace Mulimi.xcworkspace -scheme DataLayer -destination 'platform=iOS Simulator,id=125B9A31-6A4A-466D-A8AB-410730B22446' -sdk iphonesimulator -derivedDataPath /tmp/MulimiDataLayerTest -quiet통과xcodebuild test -workspace Mulimi.xcworkspace -scheme PresentationLayer -destination 'platform=iOS Simulator,id=125B9A31-6A4A-466D-A8AB-410730B22446' -sdk iphonesimulator -derivedDataPath /tmp/MulimiPresentationLayerTest -quiet통과xcodebuild build -workspace Mulimi.xcworkspace -scheme Mulimi -destination 'generic/platform=iOS' CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO -quiet통과참고:
iPhone 16 Pro, OS=latestdestination은 로컬에 없어iPhone 17 Pro, iOS 26.5시뮬레이터로 재실행했습니다.🚨 Breaking Changes
📌 Additional Notes
👀 Review Checklist