Skip to content

chore: clean up formatting#18

Open
mehtaculous wants to merge 6 commits into
mainfrom
chore/clean-up
Open

chore: clean up formatting#18
mehtaculous wants to merge 6 commits into
mainfrom
chore/clean-up

Conversation

@mehtaculous

Copy link
Copy Markdown
Collaborator

No description provided.

@mehtaculous mehtaculous self-assigned this Dec 5, 2023
@mehtaculous mehtaculous added the in review Ready for review label Dec 5, 2023
@mehtaculous

Copy link
Copy Markdown
Collaborator Author

@stevennevins can you pls improve the natspec for the getInodeAt function, I don't quite understand what it should be doing..

also improve natspec for the structs, if needed

Comment thread script/Deploy.s.sol
Comment thread src/FileSystem.sol Outdated
@stevennevins

Copy link
Copy Markdown
Collaborator

@stevennevins can you pls improve the natspec for the getInodeAt function, I don't quite understand what it should be doing..

also improve natspec for the structs, if needed

Inodes can be nested. getInodeAt traverses the directory and returns an Inode

@mehtaculous

Copy link
Copy Markdown
Collaborator Author

@stevennevins can you pls improve the natspec for the getInodeAt function, I don't quite understand what it should be doing..
also improve natspec for the structs, if needed

Inodes can be nested. getInodeAt traverses the directory and returns an Inode

so the inodeChecksum needs to be found in each path segment in the list ? seems we're iterating the list of paths but reverting after the first one if a checksum isn't found..

@stevennevins

Copy link
Copy Markdown
Collaborator

e

Yeah if it doesn't exist when traversing the list of path segments we revert

@mehtaculous

Copy link
Copy Markdown
Collaborator Author

e

Yeah if it doesn't exist when traversing the list of path segments we revert

but we're reverting after the first path..shouldn't it be at the very end ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in review Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants