Vignette: Increment progressor after iteration #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The progress bar should advance when the task has finished. Otherwise it starts and immediately increases and it stalls at 100% until the last iterations finish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the progress bar should start at 0% and reach 100% when all iterations are done. Therefore the progressor should advance when the task has finished, not when the task starts.
Otherwise the progress bar starts and immediately increases, and it stalls at 100% until the last iterations finish.
This pull request moves the
p()to the end of the iteration to reach the described effect.Thanks for your package and your time.
Feel free to close this if you disagree.