Open
Conversation
Added support for Multi-Window and related properties: https://developer.android.com/guide/topics/ui/foldables https://developer.android.com/guide/topics/ui/multi-window https://developer.android.com/guide/topics/ui/picture-in-picture https://developer.samsung.com/galaxy/foldable/techdocs https://stackoverflow.com/questions/14111052/adding-samsung-multi-window-support-to-android-application https://program.developer.samsung.com/2019/04/05/seven-mistakes-to-avoid-when-developing-for-foldable-displays Sample project settings: ``` "Android": { "MultiWindow": { "Enabled": true, "DefaultSizeWidth": "320p", "DefaultSizeHeight": "640p", "MultiInstance": true }, "PenWindow": true, "AllowMultipleResumedActivities": true, "ResizeableActivity": true, "SupportsPictureInPicture": true, "WindowLayoutInDisplayCutoutMode": 'default', "MaxAspect": "21:9", "Layout": { "DefaultHeight": "640dp", "DefaultWidth": "320dp", "Gravity": "top|end", "MinHeight": "300dp", "MinWidth": "280dp" }, ```
mortend
approved these changes
Apr 2, 2021
Member
mortend
left a comment
mortend
left a comment
There was a problem hiding this comment.
I found one small thing to nitpick on. Otherwise looks fine. :)
| <item name="android:windowContentOverlay">@null</item> | ||
| <item name="android:windowIsTranslucent">@(Project.Android.WindowIsTranslucent || 'false')</item> | ||
| #if @(Project.Android.WindowLayoutInDisplayCutoutMode:IsSet) | ||
| <item name="android:windowLayoutInDisplayCutoutMode">@(Project.Android.WindowLayoutInDisplayCutoutMode || 'default')</item> |
Member
There was a problem hiding this comment.
Nit: Looks like mixed/incorrect indentation on this line? Compare with <item ... two lines above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for Multi-Window and related properties needed to support foldable devices:
https://developer.android.com/guide/topics/ui/foldables
https://developer.android.com/guide/topics/ui/multi-window
https://developer.android.com/guide/topics/ui/picture-in-picture
https://developer.samsung.com/galaxy/foldable/techdocs
https://stackoverflow.com/questions/14111052/adding-samsung-multi-window-support-to-android-application
https://program.developer.samsung.com/2019/04/05/seven-mistakes-to-avoid-when-developing-for-foldable-displays
Sample project settings: