Skip to content

Conversation

@howardjing
Copy link

@howardjing howardjing commented Dec 3, 2017

This is the updated PR for #143, I updated to resolve merge conflicts. View at https://github.com/furqanZafar/react-selectize/pull/187/files?w=1 to ignore whitespace changes.

Original description below:


I ran into some issues with using the following properties:

  • tether
  • dropdown-direction

when using react-selectize within an application with bootstrap3 css included.

The issue seems to be a clash between bootstrap and react-selectize over the .dropdown-menu class name. I renamed dropdown-menu to rs-dropdown-menu as a sanity check, and it fixed the issues I was having.

I don't think this current PR is a great solution as it would break any existing customized css people have made for the dropdown menu, but this was the quickest fix for my purposes.

@furqanZafar I'd appreciate your input as to what you think is the best way to solve this.

See #137 for more details.

@howardjing howardjing changed the title Dropdown css rebased Fix tether and dropdown-direction compatibility with bootstrap Dec 3, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.316% when pulling d64b1a9 on howardjing:dropdown-css-rebased into d3f7072 on furqanZafar:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants