Skip to content

[Ellipsis] Refactor PackageReaderTest.java #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ellipsis-dev wants to merge 1 commit into from
Closed

[Ellipsis] Refactor PackageReaderTest.java #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/test/java/org/fungover/thunder/PackageReaderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ void socketReceiveResponseIfConnectMessageIsSent() throws IOException {
assertArrayEquals(connackMessage, bytesWritten);
}


@Test
@DisplayName("Socket receive no response if no valid connect message is sent")
void socketReceiveNoResponseIfNoValidConnectMessageIsSent() throws IOException {
Expand All @@ -87,7 +86,7 @@ void socketReceiveNoResponseIfNoValidConnectMessageIsSent() throws IOException {
}
@Test
@DisplayName("Should return false if double connect message is received")
void shouldReturnFalsseIfDoubleConnectMessageIsReceived() throws IOException {
void shouldReturnFalseIfDoubleConnectMessageIsReceived() throws IOException {
Socket socketMock = mock(Socket.class);
InputStream inputStream = new ByteArrayInputStream(new byte[]{0x10, 0x01, 0x00});
OutputStream outputStream = new ByteArrayOutputStream();
Expand All @@ -112,7 +111,6 @@ void shouldReturnFalseIfClientIsStillConnescted() throws IOException {
assertFalse(packageReader.isCleanDisconnect(address, new byte[]{(byte) 0xE0}, 1));
}


@Test
@DisplayName("Should return false if double connect message is received")
void shouldReturnFalseIfDoubleConnectMessageIsReceived() throws IOException {
Expand Down Expand Up @@ -160,4 +158,4 @@ void shouldReturnFalseIfPackageIsNotConnectPackage() throws IOException {
assertFalse(packageReader.isValidConnection(socketMock));
}

}
}