500 - Internal Server Error

[albindubech]

I think this resolves #20

[LordRekishi]

I think you got conflicts because of the changes made in merging Issue #40 earlier today. Maybe if you merge in the new main branch it could be solved?

[albindubech]

I think you got conflicts because of the changes made in merging Issue #40 earlier today. Maybe if you merge in the new main branch it could be solved?

Whould I need to create a new Pull Request for this to be made?

[LordRekishi]

I think you got conflicts because of the changes made in merging Issue #40 earlier today. Maybe if you merge in the new main branch it could be solved?

Whould I need to create a new Pull Request for this to be made?

Exactly. Update the project through intellij, and then merge main into your branch.

[Philippevial]

.

I think the pull-request updates when you push from the same branch again, so you don't need to create a new one!
(After updating the branch of course)

[albindubech]

This pull request should now be updated with the latest changes form main

[kappsegla]

The HttpResponse class holding response header seams to be a good idea. Maybe call the class HttpResponseStatusCodes or something similar? And keep the HttpResponse class available for a complete response from the server?

Hardcoding a contact adress to fungover.org in the code is a bad idea, because this server should be able to run on many different hostnames, not just ours. Suggestion to just return 500 Internal Server Error because protocol version depends on how our server is configured so something else in the code has to define that.

[albindubech]

The HttpResponse class holding response header seams to be a good idea. Maybe call the class HttpResponseStatusCodes or something similar? And keep the HttpResponse class available for a complete response from the server?

Hardcoding a contact adress to fungover.org in the code is a bad idea, because this server should be able to run on many different hostnames, not just ours. Suggestion to just return 500 Internal Server Error because protocol version depends on how our server is configured so something else in the code has to define that.

Should I rename the class to "HttpResponseStatusCodes" and leave the "HTTpResponse" name available for later use then? Or did I misunderstand?

[kappsegla]

The HttpResponse class holding response header seams to be a good idea. Maybe call the class HttpResponseStatusCodes or something similar? And keep the HttpResponse class available for a complete response from the server?
Hardcoding a contact adress to fungover.org in the code is a bad idea, because this server should be able to run on many different hostnames, not just ours. Suggestion to just return 500 Internal Server Error because protocol version depends on how our server is configured so something else in the code has to define that.

Should I rename the class to "HttpResponseStatusCodes" and leave the "HTTpResponse" name available for later use then? Or did I misunderstand?

Much better name like this.

[Vimbayinashe]

This looks good! It would be good to add tests for these changes as soon as #62 has received a second review.

[albindubech]

This looks good! It would be good to add tests for these changes as soon as #62 has received a second review.

Good suggestion, will update with tests when #62 is completed.

[Vimbayinashe]

This looks good! It would be good to add tests for these changes as soon as #62 has received a second review.

Good suggestion, will update with tests when #62 is completed.

Pull request #62 is now marked as draft as it has become dependent on another issue. I will approve this pull request now.

[ErikssonF]

Looks good!