Database testing#8
Open
armandodecanha wants to merge 4 commits into
Open
Conversation
delirial
suggested changes
Aug 1, 2019
delirial
left a comment
delirial
left a comment
Contributor
There was a problem hiding this comment.
We need to view the functionality of docker and npm script npm start before merge
| name: myment-front | ||
| description: Myment Travel app FrontEnd | ||
| name: myment_back | ||
| description: Myment Travel Web App back-end |
| @@ -1 +1,2 @@ | |||
| node_modules | |||
| .cache | |||
Contributor
There was a problem hiding this comment.
If you don't use parcel or something like that, it's not needs
| @@ -0,0 +1,6 @@ | |||
| { | |||
| @@ -1,10 +1,15 @@ | |||
| FROM node:10-alpine | |||
|
|
|||
| FROM mariadb:10.4 as database | |||
Contributor
There was a problem hiding this comment.
With this change it's work ?
| @@ -0,0 +1,29 @@ | |||
| const Sequelize = require('sequelize'); | |||
Contributor
There was a problem hiding this comment.
This is not a model, this is a mapping between model and table.
To define mappings between a model and a table, use the define method
Maybe we need a model, in the manual there is this example:
class Project extends Model {}
Project.init({
title: Sequelize.STRING,
description: Sequelize.TEXT
}, { sequelize, modelName: 'project' });| @@ -0,0 +1,9 @@ | |||
| const Sequelize = require('sequelize'); | |||
|
|
|||
| module.exports = new Sequelize('myment', 'root', '010495a', { | |||
Contributor
There was a problem hiding this comment.
This is the connection object, not a database
| "main": "index.js", | ||
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| "start": "mysqld && node app.js", |
Contributor
There was a problem hiding this comment.
msqld only ?? and it's work ?
| }, | ||
| "keywords": [], | ||
| "author": "", | ||
| "author": "FuckingBosses", |
Contributor
|
|
delirial
added
needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll try to see how heroku, and travis, and the Docker works...
And the most cool version of the database dump is here. I hope you like it.