Tag testing#11
Open
armandodecanha wants to merge 8 commits into
Open
Conversation
…make a GET request of the tags saved on the db
delirial
reviewed
Aug 7, 2019
delirial
left a comment
delirial
left a comment
Contributor
There was a problem hiding this comment.
I need some aclaration to align the revision with your proposes
| app.use((err, req, res, next) => res.status(422).send({error: err})) | ||
|
|
||
| // set the view engine to ejs | ||
| app.set("view engine", "ejs"); |
Contributor
There was a problem hiding this comment.
What is this? why a ejs parser?
Contributor
Author
There was a problem hiding this comment.
ejs is used to inject javascript inside html in a easy way.
|
|
||
| // Listen to the port set by Heroku | ||
| const port = process.env.PORT; | ||
| app.listen(port || port, () => |
Contributor
There was a problem hiding this comment.
must be app.listen(port || 3000) or something like that for case that PORT ENV variable not be setted
| build: | ||
| docker: | ||
| web: Dockerfile No newline at end of file | ||
| web: node index.js No newline at end of file |
Contributor
There was a problem hiding this comment.
Why node index.js and the dockerfile?
Contributor
Author
There was a problem hiding this comment.
I had stopped the heroku to use docker (it was giving me some errors) so I could deploy the app locally for testing...
| "ts-jest": "^24.0.2", | ||
| "ts-node": "^8.3.0" | ||
| "ts-node": "^8.3.0", | ||
| "typescript": "^3.5.2" |
|
|
||
|
|
||
| // Set the home page route | ||
| router.get("/", (req, res) => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added one example tag wich has a point coordinate to the mongoDB db.
What i'm trying to do is to connect an input wich is autocompleted with the name of the tags.