Add domain as optional secret to include for cifs mount.#13
Open
cblack34 wants to merge 2 commits intofstab:masterfrom
Open
Add domain as optional secret to include for cifs mount.#13cblack34 wants to merge 2 commits intofstab:masterfrom
cblack34 wants to merge 2 commits intofstab:masterfrom
Conversation
add code to check for domain in secrets add code to add domain to $mountOptions if domain in secrets change debugging to use bool variable instead of comments. This makes it easier to include debug logging through out the script.
update README.md to include domain options.
cblack34
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add code to check for domain in secrets
add code to add domain to $mountOptions if domain in secrets
change debugging to use bool variable instead of comments. This makes it easier to include debug logging through out the script.