Add PlayGithub local subdomain route#1069
Open
BlueHotDog wants to merge 17 commits into
Open
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| import type { Page } from "playwright"; | ||
|
|
||
| const PHOENIX_ORIGIN = "https://localhost:4002"; | ||
| const PHOENIX_ORIGIN = "https://frontman.local:4002"; |
itayadler
reviewed
Jun 2, 2026
| alias FrontmanServer.PlayGithub.GithubReference | ||
| alias FrontmanServer.PlayGithub.RepositorySandbox | ||
|
|
||
| @frontman_install_command "npx astro add @frontman-ai/astro --yes" |
Collaborator
There was a problem hiding this comment.
this is the install command for astro.. we aren't going to introduce the abstraction for this yet?
itayadler
reviewed
Jun 2, 2026
| # Authenticated users in dev see a simple "you're signed in" page | ||
| # (avoids redirect loop with signed_in_path -> / -> /users/log-in). | ||
| # Authenticated users in dev see a simple "you're signed in" page. | ||
| # Do not redirect to sudo-only routes here; expired sudo sessions would loop. |
Collaborator
There was a problem hiding this comment.
what does this mean sudo sessions?
Collaborator
Author
There was a problem hiding this comment.
there are some routes that we call "sudo" meaning they need you to auth even if you're authenticated as an extra security best-practice.
e.g things like changing your profile etc.
itayadler
reviewed
Jun 3, 2026
| "": { | ||
| "dependencies": { | ||
| "@opencode-ai/plugin": "1.14.32" | ||
| "@opencode-ai/plugin": "1.15.13" |
Collaborator
There was a problem hiding this comment.
hmm, we shouldn't commit this?
itayadler
reviewed
Jun 3, 2026
| alias FrontmanServer.PlayGithub.GithubReference | ||
| alias FrontmanServerWeb.PlayGithub.SandboxProxy.Target | ||
|
|
||
| @command_usage "?command=create|start|clone|install|dev" |
Collaborator
There was a problem hiding this comment.
this is kinda weird, why isn't this restful?
itayadler
reviewed
Jun 3, 2026
| end | ||
| end | ||
|
|
||
| defp next_step(%{provider_state: :starting}), do: "wait_for_daytona_start" |
Collaborator
There was a problem hiding this comment.
would be nice to move the state machine to its own module
itayadler
reviewed
Jun 3, 2026
| "error: unsupported_github_path\nsegments: #{Enum.join(segments, "/")}" | ||
| end | ||
|
|
||
| defp launch_page_html do |
Collaborator
There was a problem hiding this comment.
I think I added this, but should be moved to an elixir template file
itayadler
reviewed
Jun 3, 2026
|
|
||
| Target URL: https://frontman.sh/blog/best-frontend-coding-agent/ | ||
|
|
||
| Goal: boost SEO and GEO visibility for `best frontend coding agent`, `AI frontend coding agent`, `Cursor vs v0 vs Claude Code frontend`, `React AI coding agent`, and related comparison queries using real, indexable community discussion and proof. |
itayadler
reviewed
Jun 3, 2026
| @@ -0,0 +1,31 @@ | |||
| PR #1069 adds authenticated `playgithub.frontman.local` routing, GitHub-shaped path parsing, deterministic Daytona sandbox get-or-create by repo target, and repo cloning into relative `workspace`. | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hosts: []while leaving Daytona runtime env requiredDark launch / merge safety
playgithub.comis not enabled in prod config yetDAYTONA_API_KEYandDAYTONA_ORGANIZATION_IDplaceholdersTests
mix format --check-formatted config/prod.exs config/runtime.exs lib/frontman_server_web/play_github/sandbox_proxy_plug.ex lib/frontman_server_web/user_auth.exmix test test/frontman_server/play_github_test.exs test/frontman_server_web/play_github/controller_test.exs test/frontman_server_web/play_github/sandbox_proxy_test.exsMIX_ENV=prod DAYTONA_API_KEY=test DAYTONA_ORGANIZATION_ID=test CLOAK_KEY=... DISCORD_NEW_USERS_WEBHOOK_URL=... DATABASE_URL=... SECRET_KEY_BASE=... RESEND_API_KEY=... mix eval ...verified PlayGithub prod config loads ashosts: []