Skip to content

RuntimeError with stderr when subprocess fails#26

Open
mannreis wants to merge 2 commits into
mainfrom
submit-error
Open

RuntimeError with stderr when subprocess fails#26
mannreis wants to merge 2 commits into
mainfrom
submit-error

Conversation

@mannreis

Copy link
Copy Markdown

Small improvement to re-raise exception with subprocess stderr when it fails

@codecov

codecov Bot commented Apr 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/reflow/executors/slurm.py 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@antarcticrainforest antarcticrainforest left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antarcticrainforest

Copy link
Copy Markdown
Contributor

Nitpick: If you want you can write a test for the missing lines. Or simply add them to the coveragerc ignore list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants