Hotfix: patch a bug in STAC Browser that crash from undefined catch-all route param#182
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The embedded STAC Browser crashes at runtime with
TypeError: can't access property "startsWith", n is undefined. The error originates upstream insrc/router/index.js: catchAllString()returns undefined whenroute.params.pathMatchis missing, and the catch-all route's props function then calls.startsWith()on that undefined value.This is basically a bug on their side. The proper fix is a PR against STAC Browser, which we'll open upstream when we have time. For now, the low-hanging fruit is to carry a guard patch here and even if they fix this, this patch guard becomes harmless.
FYI @antarcticrainforest