Skip to content

Render Markdown in blurbs.#180

Merged
antarcticrainforest merged 5 commits into
mainfrom
markdown-support
Jun 3, 2026
Merged

Render Markdown in blurbs.#180
antarcticrainforest merged 5 commits into
mainfrom
markdown-support

Conversation

@antarcticrainforest

@antarcticrainforest antarcticrainforest commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Because of security concerns only pure text strings were allowed in the home pages blurbs.

This PR enables Markdown based rendering allowing for a minimal set of slightly more elaborate text rendering while trying to keep the system safe.

Displaying external links, line breaks, bold, recursive is now supported via simple markdown text.

@eelucio FYI, @Karinon I hope this doesn't affect your security concerns.

@BiancaWentzel

Copy link
Copy Markdown
Contributor

For me it looks fine but maybe I am not aware of security issues arising from this change

@Karinon Karinon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not going to test it locally, but I think this is fine so far.

@eelucio

eelucio commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

I did not run it locally yet (still installing stuff), I have no opiinion about security stuff, two minor things:

  • release/version metadata is inconsistent across the branch. package.json (line 3) bumps the app to 2606.0.1, but CHANGELOG.md (line 4) adds the new entry under v2606.0.0 and package-lock.json (line 2) still says 2605.2.2. That makes the release history ambiguous and leaves npm metadata out of sync.
  • apparently there are still some legacy references to FrevaGPT instead of climateclaw (but I guess that these being internal functions does not amtter)

@antarcticrainforest

Copy link
Copy Markdown
Collaborator Author

I did not run it locally yet (still installing stuff), I have no opiinion about security stuff, two minor things:

* release/version metadata is inconsistent across the branch. package.json (line 3) bumps the app to 2606.0.1, but CHANGELOG.md (line 4) adds the new entry under v2606.0.0 and package-lock.json (line 2) still says 2605.2.2. That makes the release history ambiguous and leaves npm metadata out of sync.

* apparently there are still some legacy references to FrevaGPT instead of climateclaw (but I guess that these being internal functions does not amtter)

Thanks for the hints, I've updated them now. I also replaces npm install by npm ci which wuould make the command fail package.json and package-lock.json are out of sync.

@antarcticrainforest

Copy link
Copy Markdown
Collaborator Author

https://eve.dkrz.de has those changes rendered.

@antarcticrainforest antarcticrainforest merged commit 4c35e9b into main Jun 3, 2026
6 checks passed
@antarcticrainforest antarcticrainforest deleted the markdown-support branch June 3, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants