Render Markdown in blurbs.#180
Merged
Merged
Conversation
Contributor
|
For me it looks fine but maybe I am not aware of security issues arising from this change |
Karinon
approved these changes
Jun 3, 2026
Karinon
left a comment
Collaborator
There was a problem hiding this comment.
I am not going to test it locally, but I think this is fine so far.
Collaborator
|
I did not run it locally yet (still installing stuff), I have no opiinion about security stuff, two minor things:
|
Collaborator
Author
Thanks for the hints, I've updated them now. I also replaces |
Collaborator
Author
|
https://eve.dkrz.de has those changes rendered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of security concerns only pure text strings were allowed in the home pages blurbs.
This PR enables Markdown based rendering allowing for a minimal set of slightly more elaborate text rendering while trying to keep the system safe.
Displaying external links, line breaks, bold, recursive is now supported via simple markdown text.
@eelucio FYI, @Karinon I hope this doesn't affect your security concerns.