Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes trailing-slash URL behavior across the website (components, pages, and tests) and updates internal navigation to use the project’s Link component, aligning routing with the static build structure.
Changes:
- Add trailing-slash normalization for internal links (notably in
LinkandEntryList) and update tests accordingly. - Replace raw internal
<a href="/...">links with theLinkcomponent in key pages/posts to ensure consistent locale + slash behavior. - Add
website/public/CNAMEfor custom-domain hosting and update blog/internal links to use trailing slashes.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/test/Post.integration.test.tsx | Adds missing hook mocks to stabilize Post integration tests. |
| website/test/Link.test.tsx | New unit tests covering Link trailing-slash + locale behavior. |
| website/test/LanguageToggle.test.tsx | Updates expectations to match trailing-slash normalization. |
| website/test/EntryList.test.tsx | Updates href expectations and adds a basePath normalization test. |
| website/test/EntryList.filtering.test.tsx | Updates expected blog entry hrefs to include trailing slashes. |
| website/public/CNAME | Adds custom domain configuration for the deployed static site. |
| website/pages/x402/+Page.tsx | Switches internal anchors to Link for consistent routing behavior. |
| website/components/MetadataLine.tsx | Changes date parsing to avoid timezone-induced date shifts. |
| website/components/Link.tsx | Enforces trailing slashes on internal page links before locale prefixing. |
| website/components/EntryList.tsx | Normalizes basePath and ensures generated entry URLs include trailing slashes. |
| website/blog/x402_facilitator_imagegen.mdx | Updates internal markdown links to include trailing slashes. |
| website/blog/merkle_ai_batching.tsx | Uses Link for internal navigation links. |
| website/blog/merkle_ai_batching_fundamentals.tsx | Uses Link for internal navigation links. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All internal links should be with trailing slashes.