Skip to content

fix: stylesheet links in <Head> drop entry CSS #3825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crowlKats merged 1 commit into from
May 27, 2026
+47 −1
Merged

fix: stylesheet links in <Head> drop entry CSS #3825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/fresh/src/runtime/server/preact_hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,14 @@ options[OptionsType.ATTR] = (name, value) => {

const PATCHED = new WeakSet<VNode>();

// Link rels whose presence is conceptually singleton: a `<Head>` override
// should replace the existing tag regardless of its href. Other rels
// (stylesheet, preload, alternate, ...) can legitimately appear multiple
// times with different hrefs, so href must remain part of the cache key.
function isSingletonLinkRel(rel: unknown): boolean {
return rel === "canonical" || rel === "manifest";
}

function normalizeKey(key: unknown): string {
const value = key ?? "";
const s = (typeof value !== "string") ? String(value) : value;
Expand Down Expand Up @@ -406,7 +414,10 @@ options[OptionsType.DIFF] = (vnode) => {
continue;
} else if (originalType === "meta" && key === "content") {
continue;
} else if (originalType === "link" && key === "href") {
} else if (
originalType === "link" && key === "href" &&
isSingletonLinkRel(props.rel)
) {
continue;
}

Expand Down
35 changes: 35 additions & 0 deletions packages/fresh/tests/head_test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,41 @@ Deno.test("Head - ssr - merge keyed", async () => {
expect(last?.textContent).toEqual("ok");
});

Deno.test("Head - ssr - stylesheet links with different hrefs coexist", async () => {
const handler = new App()
.appWrapper(({ Component }) => {
return (
<html lang="en">
<head>
<meta charset="utf-8" />
<link rel="stylesheet" href="/entry.css" />
</head>
<body>
<Component />
</body>
</html>
);
})
.get("/", (ctx) => {
return ctx.render(
<Head>
<link rel="stylesheet" href="https://fonts.example.com/font.css" />
</Head>,
);
}).handler();

const server = new FakeServer(handler);
const res = await server.get("/");
const doc = parseHtml(await res.text());

const hrefs = Array.from(
doc.querySelectorAll("link[rel='stylesheet']"),
).map((el) => (el as HTMLLinkElement).getAttribute("href"));

expect(hrefs).toContain("/entry.css");
expect(hrefs).toContain("https://fonts.example.com/font.css");
});

Deno.test("Head - ssr - updates link", async () => {
const handler = new App()
.appWrapper(({ Component }) => {
Expand Down
Loading