docs: remove claim that node_modules is not necessary#3795
Conversation
|
Legacy builder works without node_modules, so is https://github.com/CertainLach/freshpack Fresh itself supports working without them, the only problem is vite tooling during the compilation |
|
Since Vite is required, the "no node_modules" claim feels disingenuous now. Also, most plugins (starting with tailwind) required node_modules. |
lunadogbot
left a comment
There was a problem hiding this comment.
The change is accurate — the init template sets nodeModulesDir: "manual" in the generated deno.json (packages/init/src/init.ts:563), so a node_modules/ folder is created on first run. The marketing copy claiming "no node_modules" is misleading.
Wording reads naturally with the phrase removed. Thanks!
PR title (docs: …) and scope are good; lockfile untouched. Leaving the merge to a core team member.
lunadogbot
left a comment
There was a problem hiding this comment.
deno fmt --check fails on Ubuntu — removing ", no node_modules" leaves the lines short enough that fmt wants to rewrap both www/components/homepage/Hero.tsx:17-18 and www/components/homepage/Simple.tsx:47-48. Running deno fmt locally will fix it.
This was true for Fresh 1.x.
deno run -Ar jsr:@fresh/initcreatesnode_modules.