Skip to content

docs: remove claim that node_modules is not necessary#3795

Open
tredondo wants to merge 1 commit into
freshframework:mainfrom
tredondo:main
Open

docs: remove claim that node_modules is not necessary#3795
tredondo wants to merge 1 commit into
freshframework:mainfrom
tredondo:main

Conversation

@tredondo
Copy link
Copy Markdown

This was true for Fresh 1.x. deno run -Ar jsr:@fresh/init creates node_modules.

@tredondo tredondo changed the title www: remove claim that node_modules is not necessary docs: remove claim that node_modules is not necessary Apr 28, 2026
@CertainLach
Copy link
Copy Markdown
Contributor

Legacy builder works without node_modules, so is https://github.com/CertainLach/freshpack

Fresh itself supports working without them, the only problem is vite tooling during the compilation

@tredondo
Copy link
Copy Markdown
Author

Since Vite is required, the "no node_modules" claim feels disingenuous now.

Also, most plugins (starting with tailwind) required node_modules.

Copy link
Copy Markdown
Contributor

@lunadogbot lunadogbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is accurate — the init template sets nodeModulesDir: "manual" in the generated deno.json (packages/init/src/init.ts:563), so a node_modules/ folder is created on first run. The marketing copy claiming "no node_modules" is misleading.

Wording reads naturally with the phrase removed. Thanks!

PR title (docs: …) and scope are good; lockfile untouched. Leaving the merge to a core team member.

Copy link
Copy Markdown
Contributor

@lunadogbot lunadogbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deno fmt --check fails on Ubuntu — removing ", no node_modules" leaves the lines short enough that fmt wants to rewrap both www/components/homepage/Hero.tsx:17-18 and www/components/homepage/Simple.tsx:47-48. Running deno fmt locally will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants