-
Notifications
You must be signed in to change notification settings - Fork 749
feat: allow initalizing with "src" dir #3420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
csvn
wants to merge
1
commit into
freshframework:main
Choose a base branch
from
csvn:feat/init-src-dir
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+144
−19
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| --- | ||
| description: | | ||
| Change the source directory to effectively manage your project. | ||
| --- | ||
|
|
||
| To reduce the number of files in the root project directory, it's possible to | ||
| configure a `"src"` directory when initalizing Fresh. | ||
|
|
||
| ```sh Terminal | ||
| # Move code into "src" folder | ||
| deno run -Ar jsr:@fresh/init --src-dir | ||
| ``` | ||
|
|
||
| It's also possible to use a different folder name: | ||
|
|
||
| ```sh Terminal | ||
| deno run -Ar jsr:@fresh/init --src-dir=app | ||
| ``` | ||
|
|
||
| ## Files structure | ||
|
|
||
| When initializing the project with `--src-dir`, the structure will look roughly | ||
| like below: | ||
|
|
||
| ```txt-files Project structure | ||
| <project root> | ||
| ├── src/ | ||
| │ ├── components/ | ||
| │ │ └── Button.tsx | ||
| │ ├── islands/ | ||
| │ │ └── Counter.tsx | ||
| │ ├── routes/ | ||
| │ │ └── index.tsx | ||
| │ ├── static/ | ||
| │ ├── client.ts | ||
| │ └── main.ts | ||
| ├── deno.json | ||
| └── vite.config.ts | ||
| ``` | ||
|
|
||
| ## Updating an existing project | ||
|
|
||
| To migrate an existing Fresh project using Vite, to use a `src` directory follow | ||
| the steps below. | ||
|
|
||
| 1. Move all code related to Fresh into the `src` folder | ||
| - Move `components/`, `routes/`, `islands/`, `main.ts`, `client.ts` and any | ||
| other related code into the `src` folder | ||
| - Leave `deno.json` & `vite.config.ts` in the project root | ||
| 2. Update `vite.config.ts` and add `root: "src",` | ||
| ```diff | ||
| export default defineConfig({ | ||
| + root: "src", | ||
| plugins: [fresh()], | ||
| }); | ||
| ``` | ||
| 3. Update the `"start"` task in `deno.json` to the new `_fresh` location | ||
| ```diff | ||
| - "start": "deno serve -A _fresh/server.js", | ||
| + "start": "deno serve -A src/_fresh/server.js", | ||
| ``` | ||
|
|
||
| Success! The project should now run with `deno task`. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a good idea to put generated artifacts into the
src/folder? Even when those getgitignored, they do not belong there IMHO.