Skip to content

fix(vite): remove Deno global check #3401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marvinhagemeister merged 1 commit into from
Sep 12, 2025
Merged

fix(vite): remove Deno global check #3401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/plugin-vite/src/plugins/patches.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import babelReact from "@babel/preset-react";
import { inlineEnvVarsPlugin } from "./patches/inline_env_vars.ts";
import { removePolyfills } from "./patches/remove_polyfills.ts";
import { JS_REG, JSX_REG } from "../utils.ts";
import { denoGlobal } from "./patches/deno_global.ts";
import { codeEvalPlugin } from "./patches/code_eval.ts";

export function patches(): Plugin {
Expand Down Expand Up @@ -44,10 +43,6 @@ export function patches(): Plugin {
inlineEnvVarsPlugin(env, Deno.env.toObject()),
];

if (!options?.ssr) {
plugins.push(denoGlobal);
}

const res = babel.transformSync(code, {
filename: id,
babelrc: false,
Expand Down
36 changes: 0 additions & 36 deletions packages/plugin-vite/src/plugins/patches/deno_global.ts
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions packages/plugin-vite/tests/build_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,30 +408,6 @@ Deno.test({
sanitizeResources: false,
});

Deno.test({
name: "vite build - throw when using Deno.* global inside an island",
fn: async () => {
const fixture = path.join(FIXTURE_DIR, "deno_global_island");

await expect(buildVite(fixture)).rejects.toThrow(
"The Deno.* global cannot be used in the browser",
);
},
sanitizeOps: false,
sanitizeResources: false,
});

Deno.test({
name: "vite build - don't throw when using Deno.* global in ssr",
fn: async () => {
const fixture = path.join(FIXTURE_DIR, "deno_global_ssr");

await buildVite(fixture);
},
sanitizeOps: false,
sanitizeResources: false,
});

Deno.test({
name: "vite build - static index.html",
fn: async () => {
Expand Down
Loading