fix!: rename the _fresh build folder to .fresh (BREAKING)#3175
Conversation
7dd4c6f to
c67d14d
Compare
d9b9736 to
c807a19
Compare
c807a19 to
6519787
Compare
6519787 to
b24d008
Compare
|
I strongly object to this. Generated output should be visible in a clearly marked/named folder. Common folder names are:
The examples also are not fitting IMHO:
If no agreement on a new folder name for the generated output can be reached, please keep the |
fibibot
left a comment
There was a problem hiding this comment.
The rename touches deno.json, .gitignore, packages/init, the deploy workflow, docs, and the migration tool consistently. One thing worth confirming intent on: the asset URL prefix is still _fresh — packages/fresh/src/dev/builder.ts:333 (/_fresh/js/${BUILD_ID}/), packages/fresh/src/dev/dev_build_cache.ts:581, and packages/fresh/src/middlewares/static_files.ts:87. After this PR the on-disk folder is .fresh but the URL path served to the browser is still _fresh/js/.... packages/fresh/tests/islands_test.tsx:801 still asserts the _fresh/js/ URL too. Intentional (URL path independent of build folder), or should they move together?
- nit:
packages/update/src/update.ts:140only matchestasks.preview === "deno serve -A _fresh/server.js"as an exact string — a user who customised the preview task (e.g. added--port) won't be migrated. - nit: the migration tool doesn't touch the user project's
.gitignore, so existing projects will need a manual_fresh/→.fresh/swap there.
CI green on b24d008.
As mentioned in a prior discussion, it seemed like renaming
_freshbuild folder to.freshwould align more with generated files than the current_. This PR implements that suggestion, to make the breaking change potentially sooner rather than later.Prior arts
node_modules/.deno- Deno installed packages.vite- Cache of prebuilt packages and files.angular- Cache of built files and metadata.github/or.vscode/foldersThe
.prefix in general seems to be used either for generated files, files that should be considered "hidden", or configuration files (e.g..editorconfigor.gitignore). This seems to fit well withoutDir, and would make naming more consistent IMO.