feat: add context-batch-announcement schema publication and make schema upload script more fault-tolerant#2683
Open
JoeCap08055 wants to merge 3 commits intomainfrom
Open
Conversation
…ma upload script more fault-tolerant
JoeCap08055
requested review from
a team,
aramikm,
enddynayn and
shannonwells
and removed request for
a team,
aramikm and
shannonwells
enddynayn
reviewed
Apr 1, 2026
github-actions
bot
added
metadata-changed
enddynayn
approved these changes
Apr 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
github-actions
bot
removed
metadata-changed
shannonwells
reviewed
Apr 3, 2026
Collaborator
shannonwells
left a comment
shannonwells
left a comment
There was a problem hiding this comment.
I just want to confirm if the behavior is expected against the latest frequency docker image.
| } | ||
|
|
||
| const schemaIds = intentResponse.unwrap().schemaIds; | ||
| if (!schemaIds.isSome || schemaIds.unwrap().length === 0) { |
Collaborator
There was a problem hiding this comment.
How can we have both empty array and None as possible results?
| "deploy:mainnet:intent": "node index.mjs intents-and-schemas-to-publish.json MAINNET INTENT && exit 1", | ||
| "deploy:mainnet:schema": "node index.mjs intents-and-schemas-to-publish.json MAINNET SCHEMA && exit 1", | ||
| "deploy:paseo": "node index.mjs intents-and-schemas-to-publish.json PASEO && exit 1", | ||
| "deploy:local": "node index.mjs intents-and-schemas-to-publish.json LOCAL && exit 1" |
Collaborator
There was a problem hiding this comment.
I ran this against a frequency relay in docker and got the following, which appears to have hung. When I ran it against just a locally running, instant seal chain, it looks like it deployed everything.
Intent "ics.public-key-key-agreement" already exists with ID 21
Intent "ics.context-group-acl" already exists with ID 22
Intent "ics.context-group-metadata" already exists with ID 23
No intent exists for "ics.context-batch-announcement"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to add an additional intent & schema (
context-batch-announcement) to the list of intents & schemas to be published. Also adds some resiliency to the script & makes it idempotent.Changes to
tools/schema-upload: