Conversation
|
Tested on 2nd robot |
| public: | ||
| virtual auto GetFrame() -> timestamped_frame_t = 0; | ||
| virtual auto Restart() -> void = 0; | ||
| virtual void GetFrame(timestamped_frame_t* output) = 0; |
There was a problem hiding this comment.
Can we use a reference instead of a pointer?
|
|
||
| using timestamped_frame_t = struct TimestampedFrame { | ||
| cv::Mat frame; | ||
| double timestamp; |
There was a problem hiding this comment.
Can we add an default timestamp and set invalid to be true by default?
| @@ -22,7 +22,7 @@ MultiCameraSource::MultiCameraSource( | |||
| } | |||
| } | |||
| timestamped_frame_t timestamped_frame; | |||
There was a problem hiding this comment.
Do we need to construct a new timestamped frame every time?
|
|
||
| namespace camera { | ||
|
|
||
| const cv::Mat UVCCamera::backup_image_ = |
There was a problem hiding this comment.
Can we put backup_image in the constructor so we can make sure that the size of the backup image matches what the image size should be eg 1280 x 800 for ov9281
There was a problem hiding this comment.
Now that we have removed the old way of running localization, can we update the unambigous main to support only multi-tag or only square solve? This should probably be a seperate pr though. Also, can you clean up some of the code in multi tag solver?
2 participants
No description provided.