Skip to content

Remove slim from GET /api/v2/task-group/#3385

Merged
ychiucco merged 6 commits into
mainfrom
3384-review-whether-any-client-uses-slimfalse-for-get-apiv2task-group
Jul 2, 2026
Merged

Remove slim from GET /api/v2/task-group/#3385
ychiucco merged 6 commits into
mainfrom
3384-review-whether-any-client-uses-slimfalse-for-get-apiv2task-group

Conversation

@ychiucco

@ychiucco ychiucco commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

closes #3384

Checklist before merging into main

  • I merged main into the current branch.
  • I added an appropriate entry to CHANGELOG.md
  • All GitHub checks completed successfully, or there are failures which are clearly unrelated to this Pull Request and I opened an issue about it.
  • The reported "PR coverage" is 100%, or we briefly discussed why this is not the case.
  • I added logging to new code - if appropriate.
  • I added type hints to new code - if appropriate - and maybe I ran this command to spot some naive errors:
ty check $(git diff main --name-only ./fractal_server)

@ychiucco ychiucco linked an issue Jun 30, 2026 that may be closed by this pull request
@github-actions

This comment was marked as off-topic.

@github-actions

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/routes/api/v2
  _aux_task_group_disambiguation.py
  task_group.py
  fractal_server/app/schemas/v2
  task.py
Project Total  

This report was generated by python-coverage-comment-action

@ychiucco ychiucco requested a review from tcompa July 1, 2026 07:26
@tcompa

tcompa commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

cc @dominique-roux this PR removes a query parameter, and the default behavior changes from including many task attributes to including only a few (notably dropping e.g. the JSON schemas, to reduce the response-body size).

Can you please double check if this would break any existing use case?

@tcompa tcompa requested a review from dominique-roux July 1, 2026 07:29
@tcompa tcompa marked this pull request as ready for review July 1, 2026 07:30
@ychiucco ychiucco merged commit f955473 into main Jul 2, 2026
34 checks passed
@tcompa tcompa deleted the 3384-review-whether-any-client-uses-slimfalse-for-get-apiv2task-group branch July 2, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review whether any client uses slim=False for GET /api/v2/task-group/

2 participants