Skip to content

Dockerize#7

Draft
fpopic wants to merge 1 commit into
masterfrom
dockerize
Draft

Dockerize#7
fpopic wants to merge 1 commit into
masterfrom
dockerize

Conversation

@fpopic

@fpopic fpopic commented Oct 31, 2023

Copy link
Copy Markdown
Owner

Fixes #3

TODO

  • Add CI that build docker image and pushes to a registry
  • Add repo versioning with git tag
  • Update Readme

@fpopic fpopic changed the title (#3) Dockerize. Dockerize. Oct 31, 2023
@dkorunic

Copy link
Copy Markdown

Each RUN creates another layer and there is no need to do that. I would recommend using boolean && to merge multiple commands into a single chain that should fail (and short-circuit rest of the execution) in case of an error.

@fpopic

fpopic commented Jan 24, 2024

Copy link
Copy Markdown
Owner Author

Each RUN creates another layer and there is no need to do that. I would recommend using boolean && to merge multiple commands into a single chain that should fail (and short-circuit rest of the execution) in case of an error.

yes agree, didn't have time to make it work first and then optimize it (split builder from runtime image using multi-staged images and reduce amount of layers). If you wanna take over that task and contribute, feel free :)

@fpopic fpopic changed the title Dockerize. Dockerize Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dockerize everything

2 participants