Open
Conversation
Contributor
Author
|
@elementbound This is ready for review. All features work via TCP and Websocket in the example browser project. |
|
|
||
| private async startWebSocketServer() { | ||
| if (!this.nohub) { | ||
| throw new Error("WebSocket module not attached to nohub instance"); |
Contributor
There was a problem hiding this comment.
This could lead to an uncaught promise rejection which crashes the process, will have to check.
( Even though it's technically never supposed to happen )
| } | ||
| }, | ||
| error(socket, error) { | ||
| rootLogger.error({ error }, "TCP socket error in WebSocket proxy"); |
Contributor
There was a problem hiding this comment.
Let's use the module's own logger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #86 by providing a means for a websocket client to connect.
A simple websocket proxy is created on the server side which relays incoming connections to trimsock.
I refactored the nohub client so its extendable and different kinds of transports can be implemented.
There is now a tcp and websocket client which can be used as drop in replacements of each other.