ci(release): drop fail-closed live-Loomweave conformance gate from publish#8
Merged
Conversation
…blish The release pipeline gated `publish` on a fail-closed Live Loomweave conformance job, but no CI-reachable Loomweave oracle is provisioned (LOOMWEAVE_URL / LOOMWEAVE_LIVE_ORACLE_LOCATOR vars + LEGIS_LOOMWEAVE_HMAC_KEY secret are unset), so the job errored before publish and the v1.0.0rc4 release never reached PyPI. Remove the conformance job from release.yml (`publish` now `needs: [build]`) and delete the now-orphaned loomweave-conformance.yml (its only consumer was this gate; its daily scheduled sweep failed for the same unset-secret reason). Conformance remains available as the opt-in per-PR oracle step in ci.yml (silently skipped when LOOMWEAVE_URL is unset). CHANGELOG updated to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR removes a fail-closed “Live Loomweave conformance” gate from the release publishing pipeline, because the required Loomweave oracle configuration is not provisioned in CI and was preventing releases (including v1.0.0rc4) from being published to PyPI.
Changes:
- Removed the
conformancereusable workflow job from the release workflow sopublishonly depends onbuild. - Deleted the now-orphaned
.github/workflows/loomweave-conformance.ymlreusable workflow. - Updated the changelog entry to reflect that live Loomweave conformance remains opt-in (per-PR in
ci.yml) and no longer hard-gates PyPI publish.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CHANGELOG.md | Updates release notes to reflect removal of the fail-closed release conformance gate and document the opt-in per-PR behavior. |
| .github/workflows/release.yml | Removes the conformance gate and updates publish dependencies to unblock PyPI publishing. |
| .github/workflows/loomweave-conformance.yml | Deletes the reusable, fail-closed live oracle workflow that was only used by the removed release gate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
publishjob gated on a fail-closed Live Loomweave conformance job, but CI has no Loomweave oracle (LOOMWEAVE_URL/LOOMWEAVE_LIVE_ORACLE_LOCATORvars +LEGIS_LOOMWEAVE_HMAC_KEYsecret unset) — so it errored before publish and v1.0.0rc4 never reached PyPI.conformancejob fromrelease.yml;publishnowneeds: [build].loomweave-conformance.yml(only consumer was this gate; its daily schedule failed for the same reason).ci.yml(skipped whenLOOMWEAVE_URLunset).Unblocks publishing v1.0.0rc4 to PyPI on the next release event.
🤖 Generated with Claude Code