Draft
Conversation
Most people will not use filter for most sources so let’s only show it when filled in or when advanced settings are enabled. With advanced settings we will be able to implement less common features like archival, reduced update frequency or icon overriding. WIP because I do not like the the toggle button placement.
Currently only client side is implemented. At minimum we will want to allow URL entry but upload would be even better.
✅ Deploy Preview for selfoss canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most people will not use filter for most sources so let’s introduce advanced settings and only show filter when filled in or when advanced settings are enabled.
This will allow us to implement less common features like archival, reduced update frequency or icon overriding.
WIP because I do not like the the toggle button placement.
Also introduce “Icon override” proof of concept (only client side for now). At minimum we will want to allow URL entry but upload would be even better.