fix(ru-RU,uk-UA,pl-PL,hr-HR): guard scale ceilings in the Slavic group

[TylerVigario]

Twelfth in the fix-then-gate series. Four Slavic languages, each verified individually (their ceilings genuinely differ).

	cardinal/currency	ordinal	notes
ru-RU	10³³	10³³	TypeError crasher
uk-UA	10³⁰	10¹⁵	TypeError crasher
pl-PL	10³³	10²⁴	object-keyed scale; silently-wrong decimal
hr-HR	10³⁰	10¹⁵	TypeError crasher

Notable: pl-PL decimal (another probe false-negative)

pl's decimal looked clean to the well-formedness probe even at 40 digits — but above 10³³ it's silently wrong (spelled via integerToWords past its scale words, dropping magnitude rather than emitting undefined), the same class as the az ordinal. Guarded by code analysis, not the probe's verdict.

Fix

Entry-point pattern; ceilings derived from each table ((length + 1) * 3, units separate; pl uses Object.keys(PLURAL_FORMS).length). Decimal guarded in all four (integer-spelled fractions). The 3 SCALE_FORMS/ORDINAL_SCALES tables were already module-scope.

Verification

Per locale: well-formed string or RangeError across ±10⁴⁰; integer/ordinal/decimal boundaries confirm ceil−1 ok / ceil throws. Existing fixtures green, lint clean, 269 tests.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds explicit magnitude ceiling guards for four Slavic locales to prevent crashes and silent mis-spellings when scale tables are exceeded.

Changes:

• Introduced per-locale MAX_* exponent/limit constants derived from scale tables.
• Added entry-point range checks for cardinal/currency/ordinal (and decimal significant digits) that throw a consistent “too large” error.
• Covered a Polish-specific “silently wrong” decimal path by guarding fractional integer spelling past the cardinal ceiling.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/uk-UA.js	Adds MAX_* ceilings and guards at toCardinal/toOrdinal/toCurrency entry points.
src/ru-RU.js	Adds MAX_* ceilings and guards at toCardinal/toOrdinal/toCurrency entry points.
src/pl-PL.js	Adds MAX_* ceilings computed from PLURAL_FORMS/ORDINAL_SCALES and guards, including decimal ceiling to prevent silent mis-spellings.
src/hr-HR.js	Adds MAX_* ceilings and guards at toCardinal/toOrdinal/toCurrency entry points.

[TylerVigario]

Good call — fixed in bc8fc36. Now derives MAX_CARDINAL_EXPONENT from the max numeric key (Math.max(...Object.keys(PLURAL_FORMS).map(Number))) rather than .length, so it's robust to gaps or non-scale keys. Same 10^33 ceiling, boundary unchanged.

[TylerVigario]

Intentional, and a deliberate architecture decision earlier in this series. The contract is enforced by (1) composition — a shared helper each language calls (tooLargeError, already used here) plus the shared parse-* utils — and (2) the forthcoming fast-check gate, which verifies in-range → well-formed; out-of-range → RangeError across all 72 languages uniformly. We considered a wrapper/factory that owns the parse→guard→assemble flow and rejected it: it's template-method inheritance that takes the joining logic away from each self-contained language file (the deliberate design here). The one duplicated line — if (x >= MAX) throw tooLargeError(exp) — already composes the shared helper. A computeExponentFromScaleTable can't be shared cleanly either: the derivation genuinely differs per language (length*3, (length+1)*3, (2*length+2)*3 for long-scale -ard families, max-key for pl's object), because each indexes its scale table differently. So the per-language MAX_* block is the right home; the gate keeps them consistent by outcome. (Context: .github/instructions/scale-ceiling.instructions.md.)