make Expr.get_symbols_aux tail-rec#603
Merged
Merged
Conversation
Member
|
What about memoizing the result of the function as well? It could help I think |
Contributor
Author
|
Ah yes indeed, it's likely going to help too! :) |
Contributor
Author
|
@filipeom, I think it's fine as is and we can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experiment. This function is appearing too much in the profiling results to my taste. I made it tail-recursive by CPS transformation. I hope that TCO will reduce its cost.
If it does not fix the issue, I might go into defunctionalization. The code will likely be less readable so I'd like to try this one first. 😅