fix(persistence): suppress transient root cwd from polluting recent_folders

[forketyfork]

On every terminal spawn, the shell process briefly reports / as its working directory before startup scripts run cd to the intended target. The per-frame cwd tracker was picking up this transient state and calling appendRecentFolder("/"), so / accumulated a high visit count and floated to the top of the Cmd+O overlay for users who never intentionally navigated there.

The fix adds a cwd_settled flag to SessionState. It starts false and flips to true the first time updateCwd observes a non-root path. The appendRecentFolder call in the per-frame loop is gated on this flag, so the transient slash is never recorded. Once a session has moved past root, all subsequent cwd changes — including an explicit cd / — are tracked normally. The flag resets when a session despawns, so a restarted terminal gets a fresh settling cycle. A one-time migration strips any existing "/" entry from recent_folders on the first load after upgrading.

Closes #228

Test plan

• Open Architect fresh (or delete ~/.config/architect/persistence.toml), open a new terminal, then open the Cmd+O overlay — / should not appear in the list.
• In a running terminal, run cd /, then open Cmd+O — / should appear and increment normally on repeated visits.
• Manually add "/" = 5 under [recent_folders] in persistence.toml, restart Architect, and confirm / is gone from the overlay.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb5c0f977f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Keep / in recent folders when it is intentionally used

In the V3 load path, Persistence.load now unconditionally calls removeRecentFolder("/"), so every app startup deletes the root entry even if the user explicitly visited / and saved it in persistence.toml. This turns the migration into a permanent filter and causes / to disappear again after each restart, which contradicts the intended behavior that explicit cd / should be tracked normally once startup settles.

Useful? React with 👍 / 👎.

[forketyfork]

Removed both removeRecentFolder("/") calls from the load path. cwd_settled on SessionState already prevents the transient startup / from being recorded, so the load-time strip was redundant. A real one-time migration would need version tracking in the TOML — that's out of scope here. The removeRecentFolder helper and its tests stay, but since it's no longer called on load, an explicit cd / now survives restarts.

[Copilot]

Pull request overview

This PR fixes a bug where the root directory / was polluting the recent_folders list due to shells briefly reporting / as their working directory during startup before executing startup scripts that cd to the intended target directory.

Changes:

• Adds a cwd_settled flag to SessionState that prevents transient root directory visits from being recorded until the shell has settled into a non-root directory
• Implements a V4 persistence migration that removes spurious / entries from existing recent_folders data on first load after upgrading
• Updates documentation to note the migration behavior

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/session/state.zig	Adds cwd_settled flag that starts false and becomes true when updateCwd observes a non-root path; flag is reset when session despawns
src/app/runtime.zig	Gates appendRecentFolder call on both directory change detection and cwd_settled flag being true
src/config.zig	Adds removeRecentFolder helper and calls it during V3 and V2 persistence migrations to strip / entries; includes tests for migration and removal logic
docs/configuration.md	Documents the V4 migration that removes spurious / entries from recent_folders

Comments suppressed due to low confidence (1)

src/config.zig:1107

• The test name "Persistence.appendRecentFolder skipping logic: removeRecentFolder leaves other entries intact" is misleading. This test doesn't actually test "appendRecentFolder skipping logic" - there is no skipping logic in appendRecentFolder. The test only verifies that removeRecentFolder correctly removes the "/" entry while leaving other entries intact. Consider renaming to something like "Persistence.removeRecentFolder leaves other entries intact" for clarity.

test "Persistence.appendRecentFolder skipping logic: removeRecentFolder leaves other entries intact" {

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

There is no automated test coverage for the new cwd_settled flag behavior. While the PR includes tests for the migration logic in config.zig, there are no tests verifying that:

1. cwd_settled starts as false when a session is created
2. cwd_settled becomes true when updateCwd observes a non-root path
3. A settled session allows "/" to be tracked in recent_folders after an explicit cd /
4. The flag is properly reset when a session despawns

Given that updateCwd is macOS-only (line 443), cross-platform testing may be challenging, but consider adding at least basic unit tests for the flag logic or documenting why automated tests are not feasible.

[forketyfork]

cwd_settled is set inside updateCwd, which returns early if !spawned or dead and then calls into the macOS-only getCwd syscall. There's no injection point for a mock cwd, so a unit test would need either OS-level mocking or a live shell process — both out of scope for the existing test style. The initial value (false) and the reset on despawn are plain struct field defaults, visible directly in the struct definition.