[values4k] allow custom error messages#60
Open
MarcusDunn wants to merge 3 commits intofork-handles:trunkfrom
Open
[values4k] allow custom error messages#60MarcusDunn wants to merge 3 commits intofork-handles:trunkfrom
MarcusDunn wants to merge 3 commits intofork-handles:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #47 (by overriding to a transparent error handler) but also allows for better messages by including the failed value (either on the parse or the validate). The default behavior remains unchanged.
Example
Alternatives include:
only one
onFailurehandler which does not contain theString(if parsing) or thePRIMATIVE(if validating).I prefer having access to the value that caused the exception (but it would fix #47)
transparently throw an error every time (this allows custom error messages when parsing) and allow some sort of
onInvalidto be customized (allowing custom error messages on validation)This would be a breaking change, but otherwise is much simpler.
keep current behavior, do not allow overriding
no fix for #47, but keeps code smaller and simpler.