Test registration override using standard mappings#39
Open
manuelprinz wants to merge 1 commit intofork-handles:trunkfrom
Open
Test registration override using standard mappings#39manuelprinz wants to merge 1 commit intofork-handles:trunkfrom
manuelprinz wants to merge 1 commit intofork-handles:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more of a discussion/question PR than an actual issue: Having run into an issue with
registering, I checked the tests. The one modified here has (to me) a misleading title, becausedefaultFabrikatedoes not have anyFabrikators registered, sooverridenFabrikatedoes not override anything. (I am not a native speaker, but in my understanding the code looks more like "adding", because nothing is present to override.) I think the proposed changes make the test work in a way the title describes. But since I am not sure, I'd like some feedback on it. (I am also fairly new to the codebase.)