refactor: acled#218
Draft
nikbpetrov wants to merge 4 commits into
Draft
Conversation
Collaborator
Author
|
Parity test only on update job (not running fetch!): old vs new (main branch code vs pr code) is perfectly identical; both disagree partially (712 file diffs out of 3374) with prod but only because prod's computation of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requirements.txtchange forbase_eval- unavaoidable w/o a ton of additional hassle; comments explain why/what; will repeat for wikipediaAcledFetchFrameas well as the explicit dtype columns is smelly but can't be avoided unless we do a full refactor of acled_require_api_key()on the base class)_io._read_acled_dfr()is refactored to reuseacled._prepare_resolution_data()(DRY); this means that resolve and base_eval/naive and dummy forecaster jobs both bring in the heavy acled depsrequestsandnumpymodules but both resolve/base eval bring those in implicitly (google-cloud-storagebrings inrequests,pandasbrings innumpy) - this is behaviour not tied to this PR@backoff.on_exception on _get_access_tokenbehaviour change: instead of manual handling, we letbackoffhandle retries/erroring, matching other sources' behaviour