Forecastbench sampling#15
Merged
Merged
Conversation
Closed
simas-fri
reviewed
Jun 19, 2025
simas-fri
reviewed
Jun 19, 2025
simas-fri
reviewed
Jun 19, 2025
simas-fri
requested changes
Jun 19, 2025
simas-fri
left a comment
simas-fri
left a comment
Collaborator
There was a problem hiding this comment.
Can you add a unit test to test_ranking_sim.py to check that the new question sampling method really does give a 50:50 split for predictions, and handles dataset questions correctly?
houtanb
force-pushed
the
forecastbench-sampling
branch
from
67c6ca9 to
6520550
Compare
houtanb
force-pushed
the
forecastbench-sampling
branch
from
6520550 to
a25dcc6
Compare
Member
Author
Done in bb84703 |
Collaborator
|
Looks great to me! Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.