Remove redundant biometric auto-present from SFLoginViewController.#4044
Merged
Conversation
|
||||||||||||||||||||||||||
|
||||||||||||||||||||||||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4044 +/- ##
==========================================
+ Coverage 68.18% 68.24% +0.05%
==========================================
Files 245 245
Lines 21467 21465 -2
==========================================
+ Hits 14638 14649 +11
+ Misses 6829 6816 -13
🚀 New features to boost your workflow:
|
|
||||||||||||||||||
wmathurin
approved these changes
May 28, 2026
bbirman
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SFLoginViewController.viewDidLoad(lines 95-97)BiometricAuthenticationManagerInternal.lock()now serves as the single source of truth for auto-presenting biometric unlockautomaticPresentationflag introduced in PR Add option to automatically present biometric opt-in and lock #4041Context
PR #4041 added
automaticPresentationtolock()which auto-presents biometric on all connected scenes.SFLoginViewControllerhad its own independent auto-present logic that predated this and didn't checkautomaticPresentation. WithautomaticPresentationdefaulting totrue, both paths produced the same behavior — consolidating intolock()ensures the flag is always respected.Test plan
BiometricAuthenticationManagerTestspassautomaticPresentation = false→ biometric prompt does NOT auto-present (user must tap button)