Skip to content

Fix trait collection warning #4043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbirman merged 1 commit into from
May 23, 2026
Merged

Fix trait collection warning #4043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions libs/SalesforceSDKCore/SalesforceSDKCore/Classes/IDP/SFSDKUITableViewCell.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,20 +84,18 @@ - (instancetype)initWithStyle:(UITableViewCellStyle)style reuseIdentifier:(NSStr

[self.detailLabel.topAnchor constraintEqualToAnchor:self.titleLabel.bottomAnchor constant:4].active = YES;

[self.detailLabel.leftAnchor constraintEqualToAnchor:self.profileImageView.rightAnchor constant:12].active = YES;
[self.detailLabel.leftAnchor constraintEqualToAnchor:self.profileImageView.rightAnchor constant:12].active = YES;

[self registerForTraitChanges:@[UITraitUserInterfaceStyle.self] withHandler:^(SFSDKUITableViewCell *cell, UITraitCollection *previousCollection) {
[cell updateLayerColor];
}];
return self;
}

- (void)updateLayerColor {
self.layer.borderColor = [UIColor salesforceSystemBackgroundColor].CGColor;
}

- (void)traitCollectionDidChange:(UITraitCollection *)previousTraitCollection {
[super traitCollectionDidChange:previousTraitCollection];
if ([self.traitCollection hasDifferentColorAppearanceComparedToTraitCollection:previousTraitCollection]) {
[self updateLayerColor];
}
}

- (void)awakeFromNib {
[super awakeFromNib];
Expand Down
10 changes: 4 additions & 6 deletions native/SampleApps/RestAPIExplorer/RestAPIExplorer/ViewControllers/RootViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,10 @@ class RootViewController: UIViewController {
super.viewDidLoad()
self.view.backgroundColor = UIColor.appContentBackground

registerForTraitChanges([UITraitUserInterfaceStyle.self]) { (self: RootViewController, _: UITraitCollection) in
self.updateBorderColor()
}

NotificationCenter.default.addObserver(self,
selector: #selector(clearPopoversForPasscode),
name: NSNotification.Name(rawValue: kSFScreenLockFlowWillBegin),
Expand Down Expand Up @@ -541,12 +545,6 @@ class RootViewController: UIViewController {
return self.responseSection.container
}

override func traitCollectionDidChange(_ previousTraitCollection: UITraitCollection?) {
super.traitCollectionDidChange(previousTraitCollection)
if traitCollection.hasDifferentColorAppearance(comparedTo: previousTraitCollection) {
self.updateBorderColor()
}
}

func updateBorderColor() -> Void {
for textField in self.textFields {
Expand Down
Loading