Hide navigation bar on native login view presentation#4040
Merged
Conversation
Clang Static Analysis Issues
Generated by 🚫 Danger |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4040 +/- ##
==========================================
- Coverage 70.62% 65.73% -4.90%
==========================================
Files 245 245
Lines 21457 21458 +1
==========================================
- Hits 15155 14105 -1050
- Misses 6302 7353 +1051
🚀 New features to boost your workflow:
|
|
||||||||||||||||||
bbirman
reviewed
May 20, 2026
|
||||||||||||||||||
|
||||||||||||||||
bbirman
approved these changes
May 20, 2026
wmathurin
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SFSDKNavigationControllernavigation bar when presenting custom native login view controllers inpresentLoginView:SFLoginViewControllerhides it internally, but custom native login VCs had no such handling — resulting in an unwanted nav bar appearing on top of the app's login UI, especially on re-presentation after fallback-to-web-auth → backTest plan
testNativeLoginPresentationHidesNavigationBarpassesNativeLoginManagerTestspass