Skip to content

Hide navigation bar on native login view presentation#4040

Merged
sfdctaka merged 2 commits into
forcedotcom:devfrom
sfdctaka:hideNaviationForNativeLogin
May 20, 2026
Merged

Hide navigation bar on native login view presentation#4040
sfdctaka merged 2 commits into
forcedotcom:devfrom
sfdctaka:hideNaviationForNativeLogin

Conversation

@sfdctaka
Copy link
Copy Markdown
Contributor

Summary

  • Hide the SFSDKNavigationController navigation bar when presenting custom native login view controllers in presentLoginView:
  • Previously, the wrapping nav controller's bar (styled with Salesforce blue) was visible by default. SFLoginViewController hides it internally, but custom native login VCs had no such handling — resulting in an unwanted nav bar appearing on top of the app's login UI, especially on re-presentation after fallback-to-web-auth → back
  • Add unit test verifying the navigation bar is hidden when a native login VC is presented

Test plan

  • New unit test testNativeLoginPresentationHidesNavigationBar passes
  • Test correctly fails when the fix is reverted
  • All existing NativeLoginManagerTests pass
  • Manual verification: use an app with custom native login, trigger fallback to web auth, press back — confirm no blue nav bar appears

@sfdctaka sfdctaka requested a review from bbirman May 19, 2026 21:32
@github-actions
Copy link
Copy Markdown

1 Warning
⚠️ Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File Type Category Description Line Col
SFUserAccountManager Nullability Memory error Null passed to a callee that requires a non-null 2nd parameter 1579 15
SFUserAccountManager Nullability Memory error Null passed to a callee that requires a non-null 2nd parameter 1594 15
SFUserAccountManager Nullability Memory error nil passed to a callee that requires a non-null 2nd parameter 2229 13

Generated by 🚫 Danger

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.73%. Comparing base (439d33e) to head (6c4b0f2).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4040      +/-   ##
==========================================
- Coverage   70.62%   65.73%   -4.90%     
==========================================
  Files         245      245              
  Lines       21457    21458       +1     
==========================================
- Hits        15155    14105    -1050     
- Misses       6302     7353    +1051     
Components Coverage Δ
Analytics 70.78% <ø> (ø)
Common 71.25% <ø> (+0.27%) ⬆️
Core 57.78% <100.00%> (-7.63%) ⬇️
SmartStore 73.44% <ø> (ø)
MobileSync 88.79% <ø> (ø)
Files with missing lines Coverage Δ
...SDKCore/Classes/UserAccount/SFUserAccountManager.m 44.01% <100.00%> (-17.76%) ⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

TestsPassedSkippedFailed ❌️
AuthFlowTester UI Test Results all1 ran1 ❌
TestResult
AuthFlowTester UI Test Results all
AuthFlowTesterUITests.xctest
LegacyLoginTests.testCAOpaque_DefaultScopes_WebServerFlow()❌ failure

@github-actions
Copy link
Copy Markdown

TestsPassed ☑️SkippedFailed ❌️
SalesforceSDKCore iOS ^26 Test Results632 ran630 ✅2 ❌
TestResult
SalesforceSDKCore iOS ^26 Test Results
SFUserAccountManagerTests.testUserAccountEncoding❌ failure
SalesforceRestAPITests.testCreateQuerySearchDelete❌ failure

@github-actions
Copy link
Copy Markdown

TestsPassed ☑️SkippedFailed ❌️
SalesforceSDKCore iOS ^18 Test Results632 ran631 ✅1 ❌
TestResult
SalesforceSDKCore iOS ^18 Test Results
testCallbackSuccess()❌ failure

@sfdctaka sfdctaka merged commit 881c626 into forcedotcom:dev May 20, 2026
23 of 30 checks passed
@sfdctaka sfdctaka deleted the hideNaviationForNativeLogin branch May 20, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants