Update nightly schedule to Mon/Wed/Fri at 9:30 PM PT and fix security issues#452
Merged
Merged
Conversation
wmathurin
approved these changes
May 29, 2026
|
||||||||||||||||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #452 +/- ##
=======================================
Coverage 72.62% 72.62%
=======================================
Files 13 13
Lines 559 559
=======================================
Hits 406 406
Misses 153 153 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements W-22712082 — Cleanup CI for all Repos.
Schedule change: Nightly tests now run Mon/Wed/Fri at 9:30 PM PT (
30 5 * * 2,4,6UTC), up from Sun-only. Run cost is low (~13m) and the previous weekly cadence was missing regressions for up to 7 days during high-activity sprints (e.g., May 2026 had 57 commits). Alternates with the iOS-Hybrid nightly's Tue/Thu 9:30 PM slot.Security hardening: All workflows updated to follow the GitHub Actions injection-prevention best practices:
permissions:block added to every workflow:contents: readbaseline,pull-requests: writefor the iOS reusable workflow (usesmikepenz/action-junit-reportwithcomment: true).secrets: inheritreplaced with explicit secret pass-through; iOS reusable workflow declaresTEST_CREDENTIALS/CODECOV_TOKEN, Android reusable declaresTEST_CREDENTIALS/GCLOUD_SERVICE_KEY.${{ ... }}shell interpolation inrun:blocks refactored toenv:variables with quoted shell expansions.pull_request_targetretained with# zizmor: ignore[dangerous-triggers]and inline comment documenting the Member Check mitigation.actions/checkoutsteps setwith: persist-credentials: false.permissions:on reusable-workflow callers innightly.yamlandpr.yaml, matching the permissions declared in the iOS reusable (pull-requests: writefor action-junit-report PR comments).After this change,
zizmor --offlinereports 0 High-confidence findings across all four CI workflows.Test plan
python3 yaml.safe_load,actionlint -shellcheck=,zizmor --offline. All clean.brandonpage/SalesforceMobileSDK-ReactNative#1) targeting the samecleanup-ci-w22712082branch as this PR. The test PR triggers the new workflows against a real source change inreact.force.log.ts. No regressions observed — see linked PR for run details.permissions:blocks match the team's expected privilege levels for each workflow.🤖 Generated with Claude Code