Handle test_login_domain with or without https:// prefix#2912
Merged
wmathurin merged 1 commit intoJun 1, 2026
Conversation
TestCredentials now adds https:// if the value is just a hostname. This allows the same test_credentials.json to work on both platforms.
brandonpage
approved these changes
Jun 1, 2026
Contributor
brandonpage
left a comment
There was a problem hiding this comment.
Awesome. I was wondering if we would run into something like this with the Android being added to the RN repo.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2912 +/- ##
=========================================
Coverage 66.58% 66.58%
- Complexity 3108 3109 +1
=========================================
Files 226 226
Lines 17871 17871
Branches 2339 2339
=========================================
+ Hits 11899 11900 +1
Misses 4887 4887
+ Partials 1085 1084 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestCredentialsnow acceptstest_login_domainas either a bare hostname (login.salesforce.com) or a full URL (https://login.salesforce.com). This allows the sametest_credentials.jsonto work on both iOS and Android without platform-specific formatting.Android adds
https://if missing. iOS (companion PR) strips it if present.Test plan
test_credentials.jsonformat (withhttps://)https://)