Skip to content

Handle test_login_domain with or without https:// prefix#2912

Merged
wmathurin merged 1 commit into
forcedotcom:devfrom
wmathurin:fix-test-credentials-login-domain
Jun 1, 2026
Merged

Handle test_login_domain with or without https:// prefix#2912
wmathurin merged 1 commit into
forcedotcom:devfrom
wmathurin:fix-test-credentials-login-domain

Conversation

@wmathurin
Copy link
Copy Markdown
Contributor

Summary

TestCredentials now accepts test_login_domain as either a bare hostname (login.salesforce.com) or a full URL (https://login.salesforce.com). This allows the same test_credentials.json to work on both iOS and Android without platform-specific formatting.

Android adds https:// if missing. iOS (companion PR) strips it if present.

Test plan

  • Existing tests pass with current test_credentials.json format (with https://)
  • Tests also pass with bare hostname format (without https://)

TestCredentials now adds https:// if the value is just a hostname.
This allows the same test_credentials.json to work on both platforms.
Copy link
Copy Markdown
Contributor

@brandonpage brandonpage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I was wondering if we would run into something like this with the Android being added to the RN repo.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.58%. Comparing base (7ef093b) to head (51b6cbc).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #2912   +/-   ##
=========================================
  Coverage     66.58%   66.58%           
- Complexity     3108     3109    +1     
=========================================
  Files           226      226           
  Lines         17871    17871           
  Branches       2339     2339           
=========================================
+ Hits          11899    11900    +1     
  Misses         4887     4887           
+ Partials       1085     1084    -1     
Components Coverage Δ
Analytics 48.71% <ø> (ø)
SalesforceSDK 62.89% <ø> (+0.01%) ⬆️
Hybrid 59.30% <ø> (ø)
SmartStore 78.22% <ø> (ø)
MobileSync 82.12% <ø> (ø)
see 1 file with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wmathurin wmathurin merged commit a6452a1 into forcedotcom:dev Jun 1, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants