Skip to content

Do not add My Domain from Welcome Discovery#2909

Merged
brandonpage merged 4 commits into
forcedotcom:devfrom
brandonpage:welcome-server-list
Jun 2, 2026
Merged

Do not add My Domain from Welcome Discovery#2909
brandonpage merged 4 commits into
forcedotcom:devfrom
brandonpage:welcome-server-list

Conversation

@brandonpage
Copy link
Copy Markdown
Contributor

Two big changes:

  1. Do not persist the My Domain url chosen by the user from Welcome Discovery.
  2. Pass the selected My Domain to fetchAuthenticationConfiguration so it eventually gets set as the login server on the created user account.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

1 Warning
⚠️ libs/SalesforceSDK/src/com/salesforce/androidsdk/ui/LoginActivity.kt#L668 - Switch statement on an int with known associated constant missing case BiometricManager.BIOMETRIC_ERROR_IDENTITY_CHECK_NOT_ACTIVE

Generated by 🚫 Danger

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.41%. Comparing base (7ef093b) to head (62c68c3).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #2909      +/-   ##
============================================
- Coverage     66.58%   66.41%   -0.18%     
+ Complexity     3108     3099       -9     
============================================
  Files           226      226              
  Lines         17871    17872       +1     
  Branches       2339     2340       +1     
============================================
- Hits          11899    11869      -30     
- Misses         4887     4923      +36     
+ Partials       1085     1080       -5     
Components Coverage Δ
Analytics 48.71% <ø> (ø)
SalesforceSDK 62.57% <100.00%> (-0.32%) ⬇️
Hybrid 59.30% <ø> (ø)
SmartStore 78.22% <ø> (ø)
MobileSync 82.12% <ø> (ø)
Files with missing lines Coverage Δ
.../salesforce/androidsdk/app/SalesforceSDKManager.kt 61.57% <100.00%> (-0.28%) ⬇️
.../src/com/salesforce/androidsdk/ui/LoginActivity.kt 42.16% <100.00%> (-4.02%) ⬇️
...src/com/salesforce/androidsdk/ui/LoginViewModel.kt 89.24% <100.00%> (-0.36%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brandonpage brandonpage requested a review from sfdctaka May 29, 2026 19:44
@forcedotcom forcedotcom deleted a comment from github-actions Bot May 30, 2026
@brandonpage brandonpage merged commit ca7c5b2 into forcedotcom:dev Jun 2, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants