Skip to content

Remove remaining SalesforceReact references#2906

Merged
wmathurin merged 4 commits into
forcedotcom:devfrom
wmathurin:remove-salesforce-react-references
May 28, 2026
Merged

Remove remaining SalesforceReact references#2906
wmathurin merged 4 commits into
forcedotcom:devfrom
wmathurin:remove-salesforce-react-references

Conversation

@wmathurin
Copy link
Copy Markdown
Contributor

Summary

  • Removed android-nightly-React job from nightly workflow
  • Removed React Native Dependencies step from reusable lib workflow
  • Removed SalesforceReact from Danger's LIBS array, codecov config, and READMEs
  • Added a note in root README indicating SalesforceReact moved to SalesforceMobileSDK-ReactNative in SDK 14.0

Test plan

  • Verify nightly workflow triggers correctly without the React job
  • Verify PR workflows still detect modified libs correctly
  • Confirm codecov reporting works for remaining libraries

wmathurin added 4 commits May 26, 2026 11:05
SalesforceReact was moved to SalesforceMobileSDK-ReactNative in SDK 14.0
but references remained in CI workflows, codecov config, Danger, and READMEs.
@wmathurin wmathurin mentioned this pull request May 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.41%. Comparing base (fdb090a) to head (0ec99fc).
⚠️ Report is 18 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #2906      +/-   ##
============================================
+ Coverage     66.40%   66.41%   +0.01%     
- Complexity     3097     3099       +2     
============================================
  Files           226      226              
  Lines         17774    17774              
  Branches       2327     2327              
============================================
+ Hits          11802    11804       +2     
  Misses         4896     4896              
+ Partials       1076     1074       -2     
Components Coverage Δ
Analytics 48.71% <ø> (ø)
SalesforceSDK 62.53% <ø> (+0.02%) ⬆️
Hybrid 59.30% <ø> (ø)
SmartStore 78.22% <ø> (ø)
MobileSync 82.12% <ø> (ø)
see 2 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wmathurin wmathurin merged commit 055d136 into forcedotcom:dev May 28, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants