Add missing UI Tests.#2901
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2901 +/- ##
============================================
- Coverage 55.17% 55.07% -0.10%
+ Complexity 2509 2507 -2
============================================
Files 226 226
Lines 17781 17774 -7
Branches 2328 2327 -1
============================================
- Hits 9810 9789 -21
- Misses 6966 6980 +14
Partials 1005 1005
🚀 New features to boost your workflow:
|
…oid into missing-ui-tests
wmathurin
reviewed
May 26, 2026
| } | ||
| } | ||
|
|
||
| val deadline = System.currentTimeMillis() + LOGIN_FAILURE_SETTLE_MS |
Contributor
There was a problem hiding this comment.
Couldn't you use waitForUserCount here?
Contributor
Author
There was a problem hiding this comment.
@wmathurin I don't think so, they do opposite things. waitForUserCount waits until the desired user count is hit and breaks out asap. The code here is waiting the entire timeout to ensure a user is not added.
wmathurin
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan ID: MU-03
Gap: Server-side revocation of a non-current user's refresh token must auto-log-out only that user, leave the primary user's tokens & session intact. Surfaced two SDK gaps: (a)
currentUsercleared on one-of-N logout instead of falling back to a remaining user; (b)LOGOUT_COMPLETE_INTENT_ACTIONfires whileisLoggingOut = true, so receivers callingpeekRestClientimmediately throw.New test (file: method):
MultiUserLoginTests.kt::testMultiUser_revokeOtherUserRefreshTokenTest plan ID: NEG-Ø1
Gap: Login with a malformed consumer key in a dynamic config must fail and create no user account. Surfaced SDK gap:
debugOverrideAppConfigonly cleared on the success path, so an aborted login leaks the override into the next session/test.New test (file: method):
NegativeLoginTests.kt::testInvalidConsumerKey_loginFailsTest plan ID: NEG-Ø2
Gap: Login with an unknown scope in a dynamic config must fail and create no user account. Same
debugOverrideAppConfigleak.New test (file: method):
NegativeLoginTests.kt::testInvalidScope_loginFailsTest plan ID: NEG-03
Gap: Saving a different dynamic config in Login Options and backing out without logging in must not affect the existing user's tokens, config, or refresh capability. Same
debugOverrideAppConfigleak.New test (file: method):
NegativeLoginTests.kt::testChangeDynamicConfigWithoutLogin_existingUserUnaffectedTest plan ID: 2.7
Gap: Migrate CA-Basic (user-agent flow source) → ECA-Extended (web-server flow target). Validates new tokens are issued, the original user/scopes are preserved, and refresh works on the new app.
New test (file: method):
RefreshTokenMigrationTests.kt::testMigrateCAUserAgent_To_ECAExtendedWebServerTest plan ID: 2.8
Gap: Migrate CA-Basic (user-agent flow source) → Beacon-Extended (web-server flow target). Same expectations as 2.7 but targeting the Beacon ECA.
New test (file: method):
RefreshTokenMigrationTests.kt::testMigrateCAUserAgent_To_BeaconExtendedWebServerSupporting infrastructure
Added alongside (not new test cases, but referenced by the tests above):
AuthFlowTesterPageObject.triggerApiRequestIgnoringResult,clickAndWaitForAlertretry helper,LOGOUT_COMPLETE_INTENT_ACTIONsubscription with one-of-N fallback inAuthFlowTesterActivity, andmigrateRefreshToken_passesUseWebServerFlowFromOAuthConfig-style override plumbing exercised by the migration tests.