Skip to content

MODNOTES-294 and MODFQMMGR-1053 Add FQM config#351

Merged
mweaver-ebsco merged 1 commit intomasterfrom
MODFQMMGR-1053-add-fqm-config
Apr 3, 2026
Merged

MODNOTES-294 and MODFQMMGR-1053 Add FQM config#351
mweaver-ebsco merged 1 commit intomasterfrom
MODFQMMGR-1053-add-fqm-config

Conversation

@mweaver-ebsco
Copy link
Copy Markdown
Contributor

@mweaver-ebsco mweaver-ebsco commented Mar 31, 2026

Purpose

Describe the purpose of this pull request. Why is this change necessary? What problem does it solve?

Approach

How does this change fulfill the purpose? Provide a high-level overview of the technical approach taken to address the problem.

Changes Checklist

  • API Changes: While the API schema files were modified, these changes don't produce any changes in the generated code
  • Database Schema Changes: These DB schema changes will happen automatically in the mod-fqm-manager DB schema
  • Interface Version Changes: N/A
  • Interface Dependencies: N/A
  • Permissions: N/A
  • Logging: N/A
  • Unit Testing: N/A
  • Integration Testing: N/A
  • Manual Testing: Happening in the context of upcoming work in mod-fqm-manager
  • NEWS

Related Issues

MODFQMMGR-1053

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Folio Query Machine (FQM) configuration for mod-notes so notes, links, note-link associations, and note types can be exposed as queryable entity types with translated display labels.

Changes:

  • Introduces fqm-config.toml defining sources/entityTypes and permissions for FQM exposure.
  • Adds FQM-specific schema wrappers under src/main/resources/fqm/schemas/ and annotates existing Swagger schemas with x-fqm-* metadata.
  • Adds English translations for the new FQM entity types/fields.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
translations/mod-notes/en.json Adds UI labels/descriptions for FQM entity types and fields.
src/main/resources/swagger.api/schemas/noteType.yaml Adds FQM field metadata for note types, including value-source API info.
src/main/resources/swagger.api/schemas/note.yaml Adds FQM field metadata for notes and a join to note_type.
src/main/resources/swagger.api/schemas/link.yaml Adds FQM metadata for link fields and introduces an FQM-specific fqmLink shape.
src/main/resources/swagger.api/schemas/common.yaml Adds FQM metadata/value getters for common metadata fields.
src/main/resources/fqm/schemas/noteType.yaml Wrapper ref to Swagger noteType schema fragment for fqm-tools.
src/main/resources/fqm/schemas/noteLink.yaml Defines an FQM-only association schema for note_link.
src/main/resources/fqm/schemas/note.yaml Wrapper ref to Swagger note schema fragment for fqm-tools.
src/main/resources/fqm/schemas/link.yaml Wrapper ref to Swagger fqmLink schema fragment for fqm-tools.
fqm-config.toml Declares FQM sources/entityTypes for mod-notes (note/link/note_link/note_type).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mweaver-ebsco mweaver-ebsco force-pushed the MODFQMMGR-1053-add-fqm-config branch 2 times, most recently from 98fd658 to 06bb433 Compare March 31, 2026 20:18
@psmagin psmagin self-requested a review April 1, 2026 11:21
@mweaver-ebsco mweaver-ebsco force-pushed the MODFQMMGR-1053-add-fqm-config branch 2 times, most recently from 39bb645 to adae9fc Compare April 2, 2026 17:16
@mweaver-ebsco mweaver-ebsco force-pushed the MODFQMMGR-1053-add-fqm-config branch from adae9fc to ada1425 Compare April 3, 2026 12:41
@mweaver-ebsco mweaver-ebsco changed the title MODFQMMGR-1053 Add FQM config MODNOTES-294 and MODFQMMGR-1053 Add FQM config Apr 3, 2026
@mweaver-ebsco mweaver-ebsco force-pushed the MODFQMMGR-1053-add-fqm-config branch from ada1425 to ada1363 Compare April 3, 2026 12:42
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 3, 2026

@mweaver-ebsco mweaver-ebsco merged commit 5511bf8 into master Apr 3, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants