MODNOTES-294 and MODFQMMGR-1053 Add FQM config#351
Merged
mweaver-ebsco merged 1 commit intomasterfrom Apr 3, 2026
Merged
Conversation
mweaver-ebsco
commented
Mar 31, 2026
mweaver-ebsco
commented
Mar 31, 2026
ncovercash
reviewed
Mar 31, 2026
ncovercash
approved these changes
Mar 31, 2026
There was a problem hiding this comment.
Pull request overview
Adds Folio Query Machine (FQM) configuration for mod-notes so notes, links, note-link associations, and note types can be exposed as queryable entity types with translated display labels.
Changes:
- Introduces
fqm-config.tomldefining sources/entityTypes and permissions for FQM exposure. - Adds FQM-specific schema wrappers under
src/main/resources/fqm/schemas/and annotates existing Swagger schemas withx-fqm-*metadata. - Adds English translations for the new FQM entity types/fields.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| translations/mod-notes/en.json | Adds UI labels/descriptions for FQM entity types and fields. |
| src/main/resources/swagger.api/schemas/noteType.yaml | Adds FQM field metadata for note types, including value-source API info. |
| src/main/resources/swagger.api/schemas/note.yaml | Adds FQM field metadata for notes and a join to note_type. |
| src/main/resources/swagger.api/schemas/link.yaml | Adds FQM metadata for link fields and introduces an FQM-specific fqmLink shape. |
| src/main/resources/swagger.api/schemas/common.yaml | Adds FQM metadata/value getters for common metadata fields. |
| src/main/resources/fqm/schemas/noteType.yaml | Wrapper ref to Swagger noteType schema fragment for fqm-tools. |
| src/main/resources/fqm/schemas/noteLink.yaml | Defines an FQM-only association schema for note_link. |
| src/main/resources/fqm/schemas/note.yaml | Wrapper ref to Swagger note schema fragment for fqm-tools. |
| src/main/resources/fqm/schemas/link.yaml | Wrapper ref to Swagger fqmLink schema fragment for fqm-tools. |
| fqm-config.toml | Declares FQM sources/entityTypes for mod-notes (note/link/note_link/note_type). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mweaver-ebsco
commented
Mar 31, 2026
bvsharp
approved these changes
Mar 31, 2026
98fd658 to
06bb433
Compare
psmagin
reviewed
Apr 1, 2026
39bb645 to
adae9fc
Compare
adae9fc to
ada1425
Compare
ada1425 to
ada1363
Compare
|
psmagin
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
Describe the purpose of this pull request. Why is this change necessary? What problem does it solve?
Approach
How does this change fulfill the purpose? Provide a high-level overview of the technical approach taken to address the problem.
Changes Checklist
Related Issues
MODFQMMGR-1053