Fix for Exposing internal representation#1298
Closed
derTobsch wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Tobias Schneider <Tobias.Schneider@Tobsch.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use defensive copying and return an unmodifiable view/copy from the getter.
Best fix without changing intended functionality:
setChildren(...), copy incoming map into a newHashMapinstead of storing the passed reference.getChildren(), return an unmodifiable map (preferably an unmodifiable copy) so callers cannot mutate internal state.Collections.Edits are all in:
jollyday-core/src/main/java/de/focus_shift/jollyday/core/CalendarHierarchy.javasetChildren(...)getChildren()Suggested fixes powered by Copilot Autofix. Review carefully before merging.